Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][FIX] sale_commission_product_criteria_domain #541

Open
wants to merge 3 commits into
base: 16.0
Choose a base branch
from

Conversation

toita86
Copy link

@toita86 toita86 commented Jul 1, 2024

fwp of #538

@OCA-git-bot
Copy link
Contributor

Hi @ilyasProgrammer,
some modules you are maintaining are being modified, check this out!

Copy link

github-actions bot commented Nov 3, 2024

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Nov 3, 2024
@francesco-ooops
Copy link
Contributor

@toita86 can you rebase?

@toita86 toita86 force-pushed the 16.0-FIX-sale_commission_product_criteria_domain-toita86 branch from 10dea70 to a387ae8 Compare November 5, 2024 09:35
Copy link
Contributor

@francesco-ooops francesco-ooops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional ok!

@francesco-ooops
Copy link
Contributor

@ilyasProgrammer can you merge this one too?

@github-actions github-actions bot removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Nov 10, 2024
Copy link

@luisDIXMIT luisDIXMIT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on runboat. LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants